Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

[Amos Kariuki]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1584/
-----------------------------------------------------------

Review request for Plasma and Shawn Starr.


Summary
-------

The patch uses the REST API provided by NOAA at <http://www.weather.gov/forecasts/xml/rest.php> to obtain the forecast for the location coordinates returned by the observation data.  It requests the 7-day forecast but only displays the days for which data is available (usually 5-7 days).  The weather icon descriptions unfortunately don't match those used by the normal observation feed, and are defined at <http://www.weather.gov/forecasts/xml/DWMLgen/schema/parameters.xsd> ; we however use a similar heuristic algorithm (keyword search)) to find the best match for the returned weather conditions.

This patch also enables the normal condition icon which was being mistakenly being unset.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.cpp 1021754 
  trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.h 1016575 

Diff: http://reviewboard.kde.org/r/1584/diff


Testing
-------

Verified the NOAA forecast was displayed in the Weather Forecast applet for a few locations.


Thanks,

Amos