Review Request: forgetten slot defination

Omer F. USTA omerusta at gmail.com
Sat Sep 12 00:09:50 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1569/
-----------------------------------------------------------

Review request for Plasma and Aaron Seigo.


Summary
-------

checkAvailability must be a slot because it was used by connect(....  in plasma-desktop-runner.cpp:45
    QObject::connect(QDBusConnection::sessionBus().interface(), SIGNAL(serviceOwnerChanged(QString,QString,QString)),
                     this, SLOT(checkAvailability(QString,QString,QString)));


This addresses bugs a, be, checkAvailability, instead, method, must, normal, of, and slot.
    https://bugs.kde.org/show_bug.cgi?id=a
    https://bugs.kde.org/show_bug.cgi?id=be
    https://bugs.kde.org/show_bug.cgi?id=checkAvailability
    https://bugs.kde.org/show_bug.cgi?id=instead
    https://bugs.kde.org/show_bug.cgi?id=method
    https://bugs.kde.org/show_bug.cgi?id=must
    https://bugs.kde.org/show_bug.cgi?id=normal
    https://bugs.kde.org/show_bug.cgi?id=of
    https://bugs.kde.org/show_bug.cgi?id=slot


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/runners/plasma-desktop/plasma-desktop-runner.h 1022509 

Diff: http://reviewboard.kde.org/r/1569/diff


Testing
-------


Thanks,

Omer F.



More information about the Plasma-devel mailing list