Review Request: Convert weather code to use KUnitConversion (kdebase)

Shawn Starr shawn.starr at rogers.com
Mon Sep 7 19:07:35 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1529/#review2262
-----------------------------------------------------------

Ship it!


Looks good to me, SHIP IT!

- Shawn


On 2009-09-07 09:37:20, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1529/
> -----------------------------------------------------------
> 
> (Updated 2009-09-07 09:37:20)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Convert weather code to use KUnitConversion.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_bbcukmet.cpp 1020445 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_envcan.cpp 1020445 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.cpp 1020445 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/weatherutils.h 1020445 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/weatherutils.cpp 1020445 
> 
> Diff: http://reviewboard.kde.org/r/1529/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>



More information about the Plasma-devel mailing list