[PATCH] BUG 202473 no sound on emptying trash widget although sound is configured in systemsettings

["潘卫平(Peter Pan)"]

Alessandro Diaferia 写道:
> 
> 
> 2009/9/1 "潘卫平(Peter Pan)" <wppan at redflag-linux.com 
> <mailto:wppan at redflag-linux.com>>
> 
>     Hi, all
> 
>     The plasma trash applet doesn't emit a KNotification when the trash is
>     emptied, so there is no sound.
> 
> 
>     Regards
> 
>     --
>     潘卫平(Peter Pan)
>     Red Flag Software Co., Ltd
> 
>     _______________________________________________
>     Plasma-devel mailing list
>     Plasma-devel at kde.org <mailto:Plasma-devel at kde.org>
>     https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> 
> 
> +1 for committing this patch from my side
> 
> Just one little side note: is it really needed to do 
> emptyTrash->setEnabled(false); again in the emptyFinished slot?
> 
> -- 
> Alessandro Diaferia
> KDE Developer
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
yes, no need.
I think emptyTrash->setEnabled() and emptyTrash->setText() are not 
necessary.
The modified patch is followed.

Regards
-- 
潘卫平(Peter Pan)
Red Flag Software Co., Ltd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase-plasma-trash-empty.patch
Type: text/x-patch
Size: 1116 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090901/13522ed8/attachment.patch