Review Request: Plasma Netbook animated Version 1

[igorto]

> On 2009-10-29 21:23:59, Marco Martin wrote:
> > trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h, line 9
> > <http://reviewboard.kde.org/r/2008/diff/2/?file=13499#file13499line9>
> >
> >     QGraphicsLayoutItem should be more than enough

done


> On 2009-10-29 21:23:59, Marco Martin wrote:
> > trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h, line 9
> > <http://reviewboard.kde.org/r/2008/diff/2/?file=13509#file13509line9>
> >
> >     just generic code style stuff: all this block should be indented a level less, so public: at the level of {

done


- igorto


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2008/#review2856
-----------------------------------------------------------


On 2009-10-30 03:40:42, igorto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2008/
> -----------------------------------------------------------
> 
> (Updated 2009-10-30 03:40:42)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> Add animated layouts to plasma-netbook.
> Animate add/remove widgets in layouts(grid and linear).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h 1042281 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 
> 
> Diff: http://reviewboard.kde.org/r/2008/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> igorto
> 
>