Review Request: plasmapkg & wallpaper

[Aaron J. Seigo]

On October 29, 2009, Thomas Olsen wrote:
> On 29/10-2009 19:56 "Aaron J. Seigo" <aseigo at kde.org> wrote:
> > On October 29, 2009, Thomas Olsen wrote:
> > > On 29/10-2009 18:49 "Aaron J. Seigo" <aseigo at kde.org> wrote:
> > > > On October 29, 2009, Thomas Olsen wrote:
> > > > >  maybe add a "--force-overwrite" option or something like that.
> > > >
> > > > it already has one: "--upgrade".
> > >
> > > Which isn't enough at it's current state. See below.
> >
> > i see something about -i, not -u below?
> 
> Ah - forgot to mention that it failed with the same error: "Plugin
>  <package> is not installed."
> 
> > > > > I don't know if Plasma::PackageStructure->uninstallPackage() has
> > > > > any error checking
> > > >
> > > > some but not enough, really.
> > > >
> > > > > (couldn't find it on websvn) but it has failed for me at some
> > > > > occasions where it removed the content and not the directory
> > > > > therefore letting plasmapkg fail on both -i and -r.
> > > >
> > > > "the content"? you mean the service file? or?
> > >
> > > I should have checked it more thoroughly but at that time I just wanted
> > > it to work. I had removed with plasmapkg -r. then I tried to reinstall
> > > with plasmapkg -i with no success. Tried to remove it again but got the
> > > error message that the package wasn't installed. Scratched my head for
> > > ½ minute and checked it ~/.kde/share/apps/plasmoids/<package> was still
> > > there. It was and when I deleted it the re-installation succeeded. Next
> > > time (if any such) I will check which files are actually removed.
> >
> > better, i suppose, would be to locate the code path that leads to the
> > directory not being removed and fix that. perhaps -i on error could
> > suggest using -u in such cases as well?
> 
> You're right. Where is Plasma::PackageStructure found? I may be blind but I
> couldn't find it.

kdelibs/plasma/packagestructure.*

the individual implementations for applet, wallpaper, etc. are in:

kdelibase/plasma/private/packages.cpp

plasmapkg (just in case, because it's in an "odd" place too) is in:

kdebase/runtime/plasma/tools/plasmapkg

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20091029/57f893ef/attachment.sig