Review Request: Find applets based on the URL dropped

Aaron Seigo aseigo at kde.org
Thu Oct 29 02:30:07 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2005/#review2848
-----------------------------------------------------------

Ship it!


impressive what's possible with so little code

- Aaron


On 2009-10-29 00:12:31, Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2005/
> -----------------------------------------------------------
> 
> (Updated 2009-10-29 00:12:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add capability for Applets to specify X-Plasma-DropUrlPatterns, a QStringList of globs to match a URL dropped onto Plasma. This is orthogonal to the mimetype checking.
> 
> It's implemented as an additional static method: KPluginInfo::List Plasm::Applet::listAppletInfoForUrl(const QUrl &url);
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/applet.h 1041978 
>   /trunk/KDE/kdelibs/plasma/applet.cpp 1041978 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 1041978 
>   /trunk/KDE/kdelibs/plasma/data/servicetypes/plasma-applet.desktop 1041978 
> 
> Diff: http://reviewboard.kde.org/r/2005/diff
> 
> 
> Testing
> -------
> 
> Tested dropping URLs from webservers, akonadi, images, no strange behaviour found. There seems to be a crash in the Previewer Widget, but it's unrelated to this patch. I'm investigating..
> 
> 
> Thanks,
> 
> Sebastian
> 
>



More information about the Plasma-devel mailing list