Review Request: WallpaperScript

[Petri Damstén]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1984/
-----------------------------------------------------------

(Updated 2009-10-28 08:49:03.341028)


Review request for Plasma.


Changes
-------

* ScriptEngine and Wallpaper are both QObjects so WallpaperScript cannot inherit both. Added a small helper class for this (not a best name perhaps). Or should WallpaperScript not inherit ScriptEngine?
* I have done some work with python but currently it just paints wallpaper with single color.
* plasmapkg modifications are on the way too.


Summary
-------

Adds WallpaperScript for scripted wallpaper plugins.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/wallpaper.h 1041546 
  /trunk/KDE/kdelibs/plasma/scripting/wallpaperscript.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1041546 
  /trunk/KDE/kdelibs/plasma/packagestructure.cpp 1041546 
  /trunk/KDE/kdelibs/plasma/plasma.h 1041546 
  /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1041546 
  /trunk/KDE/kdelibs/plasma/scripting/scriptengine.h 1041546 
  /trunk/KDE/kdelibs/plasma/scripting/scriptengine.cpp 1041546 
  /trunk/KDE/kdelibs/plasma/scripting/wallpaperscript.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1041546 

Diff: http://reviewboard.kde.org/r/1984/diff


Testing
-------


Thanks,

Petri