Review Request: Add to the devicenotifier configuration buttons to open related kcms
Jacopo De Simoi
wilderkde at gmail.com
Mon Oct 26 19:33:26 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1979/
-----------------------------------------------------------
(Updated 2009-10-26 18:33:26.585079)
Review request for Plasma, Aaron Seigo, Trever Fischer, and Kevin Ottens.
Changes
-------
I should really learn to write more descriptive summaries ;)
Summary (updated)
-------
This patch adds to the configuration interface two buttons which links to two related kcms;
(btw, what is the situation with the device-automounter? I could only find a copy in kdereview)
* If you think it's worth to add such options, please help with the naming.. I've no good ideas today ;)
* Is there a template for non-trivial plasmoid config uis?
This addresses bugs 187054 and 194894.
https://bugs.kde.org/show_bug.cgi?id=187054
https://bugs.kde.org/show_bug.cgi?id=194894
Diffs
-----
trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/configurationpage.ui 1040042
trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.h 1040042
trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.cpp 1040042
Diff: http://reviewboard.kde.org/r/1979/diff
Testing
-------
It works as expected
Screenshots
-----------
new config window
http://reviewboard.kde.org/r/1979/s/239/
Thanks,
Jacopo
More information about the Plasma-devel
mailing list