Review Request: Make it possible to list installed wallpaper plugins in the plasmoid viewer

Aaron Seigo aseigo at kde.org
Mon Oct 26 18:23:12 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1973/#review2813
-----------------------------------------------------------

Ship it!


one can already list wallpapers (including the modes in each plugin) with plasmawallpaperviewer, but this can't hurt either. :)


trunk/KDE/kdebase/workspace/plasma/generic/shells/plasmoidviewer/fullview.cpp
<http://reviewboard.kde.org/r/1973/#comment2187>

    ?



trunk/KDE/kdebase/workspace/plasma/generic/shells/plasmoidviewer/main.cpp
<http://reviewboard.kde.org/r/1973/#comment2188>

    perhaps better wording would be "Requires a containment plugin to be specified."


- Aaron


On 2009-10-26 00:58:37, Aleix Pol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1973/
> -----------------------------------------------------------
> 
> (Updated 2009-10-26 00:58:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds the new option to the binary and copies the code that lists applets to list wallpapers and containments.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/shells/plasmoidviewer/fullview.cpp 1039527 
>   trunk/KDE/kdebase/workspace/plasma/generic/shells/plasmoidviewer/main.cpp 1039527 
> 
> Diff: http://reviewboard.kde.org/r/1973/diff
> 
> 
> Testing
> -------
> 
> i just ran it and it kind of worked.
> 
> 
> Thanks,
> 
> Aleix
> 
>



More information about the Plasma-devel mailing list