Review Request: use QGraphicsOpacityEffect in FadeAnimation

Giulio Camuffo giuliocamuffo at gmail.com
Wed Oct 21 18:50:04 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1860/
-----------------------------------------------------------

(Updated 2009-10-21 16:50:04.694209)


Review request for Plasma and Adenilson Cavalcanti.


Changes
-------

corrected an error in the patch


Summary
-------

This little patch makes the FadeAnimation use QGraphicsOpacityEffect instead of setting the opacity directly on the widget.
This solves a graphical glitch with Plasma::Label.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/animations/fade.h 1038220 
  /trunk/KDE/kdelibs/plasma/animations/fade.cpp 1038367 

Diff: http://reviewboard.kde.org/r/1860/diff


Testing
-------

tested, works


Thanks,

Giulio



More information about the Plasma-devel mailing list