Review Request: Animator::registerScrollingWidget()

[Adenilson Cavalcanti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1892/#review2730
-----------------------------------------------------------

Ship it!


- Adenilson


On 2009-10-19 12:59:46, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1892/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 12:59:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> provide the Animator::registerScrollingManager(qgraphicsidget) function.
> the animator creates a kineticscroll and associates it with the widget. in this way we can use kineticscroll outside of libplasma with a single call.
> another option would be to export kineticscroll with just the constructor and nothing else but i don't like it so much, unless it could make sense the behaviour of kineticscroll could be controlled with some methods (i would like it as less controllable as possible).
> 
> Do we want to totally deprecate Animator or still be able to provide functions to it? (in this case the implementation should be moved outside of deprecated and a -second- dpointer should be provided)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/animator.h 1037518 
>   /trunk/KDE/kdelibs/plasma/deprecated/animator.cpp 1037518 
>   /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1037518 
>   /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1037518 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1037518 
>   /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1037518 
> 
> Diff: http://reviewboard.kde.org/r/1892/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>