Review Request: custom toolbox support

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1861/
-----------------------------------------------------------

(Updated 2009-10-17 21:48:21.172052)


Review request for Plasma.


Changes
-------

export a really minimal ToolBox, almost totally pure virtual.
the old toolbox base class becomes InternalToolBox, it's still there because it hoffers quite a lot of stuff that isn't really appropriate to export (perhaps the files should be renamed too)


Summary
-------

this adds a setToolboxItem function.
it makes possible for the openToolBox() function to work if the containment totally manages the toolbox by itself.
it uses a "showing" property that custom toolboxes should implement to show/hide the toolbox


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1036057 
  /trunk/KDE/kdelibs/plasma/applet.cpp 1036057 
  /trunk/KDE/kdelibs/plasma/containment.h 1036057 
  /trunk/KDE/kdelibs/plasma/containment.cpp 1036057 
  /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1036057 
  /trunk/KDE/kdelibs/plasma/private/desktoptoolbox_p.h 1036057 
  /trunk/KDE/kdelibs/plasma/private/paneltoolbox.cpp 1036057 
  /trunk/KDE/kdelibs/plasma/private/paneltoolbox_p.h 1036057 
  /trunk/KDE/kdelibs/plasma/private/toolbox.cpp 1036057 
  /trunk/KDE/kdelibs/plasma/private/toolbox_p.h 1036057 
  /trunk/KDE/kdelibs/plasma/toolbox.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/toolbox.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1861/diff


Testing
-------


Thanks,

Marco