Review Request: use QGraphicsOpacityEffect in FadeAnimation
Aaron Seigo
aseigo at kde.org
Fri Oct 16 18:07:46 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1860/#review2666
-----------------------------------------------------------
why are there data members not in a dptr in an exported class?
/trunk/KDE/kdelibs/plasma/animations/fade.cpp
<http://reviewboard.kde.org/r/1860/#comment1982>
if there was a previous call to setWidget, should the old m_opacityEffect be deleted first?
- Aaron
On 2009-10-16 09:49:51, Giulio Camuffo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1860/
> -----------------------------------------------------------
>
> (Updated 2009-10-16 09:49:51)
>
>
> Review request for Plasma and Adenilson Cavalcanti.
>
>
> Summary
> -------
>
> This little patch makes the FadeAnimation use QGraphicsOpacityEffect instead of setting the opacity directly on the widget.
> This solves a graphical glitch with Plasma::Label.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/animations/fade.h 1036002
> /trunk/KDE/kdelibs/plasma/animations/fade.cpp 1036002
>
> Diff: http://reviewboard.kde.org/r/1860/diff
>
>
> Testing
> -------
>
> tested, works
>
>
> Thanks,
>
> Giulio
>
>
More information about the Plasma-devel
mailing list