Review Request: Move activation of Present Windows effect to WindowsEffects

Martin Gräßlin kde at martin-graesslin.com
Thu Oct 15 11:03:41 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1852/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Added two methods to WindowsEffects to activate the Present Windows effect either for windows on a desktops or for a group of windows and replaced it in the currentappcontrol and tasks applets.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1030597 
  trunk/KDE/kdebase/workspace/plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp 1030597 
  trunk/KDE/kdelibs/plasma/windoweffects.h 1034782 
  trunk/KDE/kdelibs/plasma/windoweffects.cpp 1034782 

Diff: http://reviewboard.kde.org/r/1852/diff


Testing
-------

Currentappcontrol is still working. The activation for grouped tasks does not work (and didn't before) or I don't know how to trigger it ;-)


Thanks,

Martin



More information about the Plasma-devel mailing list