Review Request: Kineticscrolling: a zero api approach

Marco Martin notmart at gmail.com
Wed Oct 14 11:23:44 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1840/
-----------------------------------------------------------

(Updated 2009-10-14 09:23:44.263181)


Review request for Plasma.


Changes
-------

events protected.
parent is a qgraphicswidget


Summary
-------

this is just an experiment that has perhaps a too big disadvantage to be practical...
makes use of event filters instead of explicitly forwarding mouse events.
the advantage is that it would be super easy to use and woouldn't be needed to export new classes in plasma, there could just be an 
Animator::registerScrollingManager(QGraphicsWidget *) function

the big disadvantage is that is less controllable, so widgets can't decide to -not- make use of the kineticscrolling, thing that is quite needed in WebView.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1034839 
  /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1034839 
  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1034839 
  /trunk/KDE/kdelibs/plasma/widgets/webview.h 1034839 
  /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1034839 

Diff: http://reviewboard.kde.org/r/1840/diff


Testing
-------


Thanks,

Marco



More information about the Plasma-devel mailing list