Review Request: 'Next image' action for image plugin (and wallpaper contextual actions) - kdelibs diff

[Yuen Hoe Lim]

> On 2009-10-12 20:12:52, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/wallpaper.cpp, line 424
> > <http://reviewboard.kde.org/r/1821/diff/1/?file=12456#file12456line424>
> >
> >     looks good... but I wonder, will wallpapers want to change their actions when constraints change? will any wallpapers want to dynamically generate the list of events when it's about to be shown? hmm.
> >     we might want to add more functions in the future to enable such things. but we don't need to add them yet. so nevermind. :)

You're right that generating the list of actions when it's about to be shown cannot be done right now, but the wallpaper is usually aware of it when its own constraints change, so it could generate and set a new list of contextual actions then (instead of waiting for a contextmenu event) and achieve the same effect. Should work for most cases, at least as far as I can imagine now :)


- Yuen Hoe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1821/#review2620
-----------------------------------------------------------


On 2009-10-11 14:16:33, Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1821/
> -----------------------------------------------------------
> 
> (Updated 2009-10-11 14:16:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> (I can't get my changes in kdebase and kdelibs into the same diff, so this is 'diff 1 of 2', with the kdelibs changes)
> 
> Adds support for wallpaper plugins to specify their own contextual actions that will be added to the containment context menu. These wallpaper contextual actions can be enabled/disabled like any other contextual actions via the mouse plugin context menu configuration ui (by checking/unchecking 'Wallpaper Actions').
> 
> Also adds a 'Next Wallpaper Image' contextual action for the image wallpaper plugin using this new support. This functionality only activates when image plugin is in 'slide show' mode (and of course if it is enabled in the mouse plugin ui).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/wallpaper.h 1033391 
>   /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1033391 
> 
> Diff: http://reviewboard.kde.org/r/1821/diff
> 
> 
> Testing
> -------
> 
> Built and briefly tested the functionalities mentioned in the description - they work fine as far as I can tell.
> 
> 
> Thanks,
> 
> Yuen Hoe
> 
>