Review Request: Fix several kdelibs/plasma issues reported by krazy2 and some compiler warnings

Darío Andrés andresbajotierra at gmail.com
Tue Oct 13 01:29:49 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1837/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

A bunch of small fixes reported by Krazy2 and by the compiler. I'm posting this here to not break kdelibs without permission :)
There are still some things to fix QtWidgets->KDEWidgets and some i18n and spelling errors in APIDOX.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/containmentactions.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/context.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/framesvg.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/popupapplet.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/nativetabbar.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/runnersyntax.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/checkbox.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/frame.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/itembackground.h 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/label.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/radiobutton.cpp 1034418 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/toolbutton.cpp 1034418 

Diff: http://reviewboard.kde.org/r/1837/diff


Testing
-------

The code compiles. The changes should not affect the code behavior.


Thanks,

Darío



More information about the Plasma-devel mailing list