Review Request: kineticscrolling, with pixel based properties

Marco Martin notmart at gmail.com
Wed Oct 7 21:54:07 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1799/
-----------------------------------------------------------

(Updated 2009-10-07 19:54:07.402461)


Review request for Plasma, igorto and Adenilson Cavalcanti.


Changes
-------

webview unbroken too


Summary
-------

ok, i know it's a total change again, my bad (and the patch got huge before starting to work, sadly)
but this uses the scrollPosition, viewportRect and contentsSize properties for kineticscrolling.

now the api is similar to what webkit offers and horizontal and vertical scroll is done in a single pass.
still some behaviour bug and
bouncing still not supported


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1032381 
  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1032381 
  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1032381 
  /trunk/KDE/kdelibs/plasma/widgets/webview.h 1032381 
  /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1032381 

Diff: http://reviewboard.kde.org/r/1799/diff


Testing
-------


Thanks,

Marco



More information about the Plasma-devel mailing list