New devicenotifier moved to kdereview

[Aaron J. Seigo]

On October 6, 2009, Jacopo De Simoi wrote:
> On Tuesday 06 October 2009 22:17:02 Aaron J. Seigo wrote:
> > so much for simplicity :/
> 
> I'm confused; I can read in test-predicate-openinwindow.desktop:
> 
> X-KDE-Solid-Predicate=[ [ StorageVolume.ignored == false AND [
>  StorageVolume.usage == 'FileSystem' OR StorageVolume.usage == 'Encrypted'
>  ] ] OR [ IS StorageAccess AND StorageDrive.driveType == 'Floppy' ] ]
> 
> Removing the first check should be enough; why is it not so?

because these devices may not be user-mountable, showing them if they aren't 
mounted will only result in failure.

i suppose we could do further filtering in the device notifier widget (check 
to see if it's mounted before showing it; if it isn't mounted, create a Solid 
object for it and connect to the accessibility changed signal, etc), but then 
this creates problems for anyone else who wants to use the hotplug widget 
since the ignored flag will be, rather unexpectedly, ignored.

the hotplug engine really ought to be about hotplugged devices.

if we want to show other devices, that's what we have the soliddevice and/or 
the Solid API for.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20091006/bc292f76/attachment.sig