New devicenotifier moved to kdereview

[Aaron J. Seigo]

On October 6, 2009, Giulio Camuffo wrote:
> In data martedì 06 ottobre 2009 18:16:23, Aaron J. Seigo ha scritto:
> : > On October 6, 2009, Giulio Camuffo wrote:
> : >
> > > or do you mean it doesn't show your / or /home? unfortunately the
> > >  dataengines don't manage volumes handles by fstab, but only by hal
> >
> > it doesn't show either of my disk partitions or the internal disk either.
> > i don't expect fstab style handling, but i was surprised to see that my
> > fixed hard disk didn't show up when i selected that option. the only
> > reason i could imagine is that those volumes are not user mountable.
> >
> > looking at the code it does indeed use the hotplug engine for this and it
> >  only shows devices for which there are action files. obviously there are
> >  no action files for the internal hard disk ;)
> >
> > so ... should we add an action file for fixed disks or should the
> > notifier widget look into the soliddevice engine, or...? it's hard for me
> > to say without knowing what the intended use of that feature is.
> 
> in my opinion the applet should show all the devices, fixed or not, fstab
>  or not. i tried with the solidengine, but it doesn't show the other
>  devices too.

the soliddevice DataEngine shows them here with this as the source name:

[ StorageVolume.usage == 'FileSystem' OR StorageVolume.usage == 'Encrypted' ]

>  i think anyway a better approach would be to add an action
>  file for them, and add a property in the DeviceItem to set if they are
>  (un)mountable

it would prevent any special-case code in the notifier widget, yes.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20091006/3f84c252/attachment.sig