Review Request: Plasma D-Bus Interface: Setting wallpaper image

[Ivan Cukic]

> On 2009-10-06 19:05:00, Aaron Seigo wrote:
> > shouldn't the wallpaper export its own dbus interface, and the path to that dbus object be dependent on the containment id? e.g. something like Containments/1/Wallpaper? then instead of a plugin-specific hack, we could have per-plugin controls on the bus?

The main reason for this is that it provides a quick, minimal change that provides the desired functionality (no changes in the libplasma, wallpaper plugins, ... just PlasmaApp).

I agree that the d-bus objects for each containment/wallpaper would be a much cleaner solution*, but it would need a lot of work that nobody (including myself) doesn't seem to have the time to do now (as it seems).

So, we have a lot ppl asking for this while we could remove the function once we get the more detailed one (if there is a need for that at all) since we don't need to probide d-bus API compatibility.

* Although a bit overblown IMO.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1798/#review2568
-----------------------------------------------------------


On 2009-10-06 11:28:00, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1798/
> -----------------------------------------------------------
> 
> (Updated 2009-10-06 11:28:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> There are many users who want the way to set the wallpaper via d-bus.
> 
> This enables them to do so, but only for the image wallpaper.
> 
> Since there is no mechanism in Plasma::Wallpaper (as far as I know) to set wallpaper options from outside of the wallpaper plugin, this patch relies on the structure of the Image wallpaper plugin and its configuration file format.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/dbus/org.kde.plasma.App.xml 1031712 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h 1031712 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1031712 
> 
> Diff: http://reviewboard.kde.org/r/1798/diff
> 
> 
> Testing
> -------
> 
> Testing done - changing the wallpaper from one image to another, from another plugin to image plugin.
> 
> 
> Thanks,
> 
> Ivan
> 
>