Review Request: Unified ItemBackground in new Device Notifier

[Aaron Seigo]

> On 2009-10-06 02:00:26, Chani wrote:
> > /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.cpp, line 489
> > <http://reviewboard.kde.org/r/1790/diff/3/?file=12372#file12372line489>
> >
> >     commented out code... is it dead? should it be removed?

yes, removed now in my local copy


> On 2009-10-06 02:00:26, Chani wrote:
> > /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.h, line 306
> > <http://reviewboard.kde.org/r/1790/diff/3/?file=12371#file12371line306>
> >
> >     there are two of them now, with the exact same comment. can you change the comment to explain how they're different?

fixed


> On 2009-10-06 02:00:26, Chani wrote:
> > /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.h, line 196
> > <http://reviewboard.kde.org/r/1790/diff/3/?file=12369#file12369line196>
> >
> >     grammar!

details ;P


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1790/#review2559
-----------------------------------------------------------


On 2009-10-05 23:27:10, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1790/
> -----------------------------------------------------------
> 
> (Updated 2009-10-05 23:27:10)
> 
> 
> Review request for Plasma, Jacopo De Simoi and Giulio Camuffo.
> 
> 
> Summary
> -------
> 
> proof of concept showing how the item background could be unified into NotifierDialog; requires today's libplasma for fixes to the ItemBackground widget
> 
> 
> Diffs
> -----
> 
>   /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.h 1031762 
>   /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp 1031762 
>   /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.h 1031762 
>   /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.cpp 1031762 
> 
> Diff: http://reviewboard.kde.org/r/1790/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
>