Review Request: configurable default mouse plugins

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1760/#review2554
-----------------------------------------------------------

Ship it!


it's a bit odd that ContainmentActionsConfig doesn't have any getters, only seters, but i agree that there is no point to having them currently. we may end up adding them later, but that is BC.


/dev/null
<http://reviewboard.kde.org/r/1760/#comment1868>

    @since 4.4



/dev/null
<http://reviewboard.kde.org/r/1760/#comment1866>

    newline



/dev/null
<http://reviewboard.kde.org/r/1760/#comment1867>

    newline


- Aaron


On 2009-10-04 00:09:12, Chani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1760/
> -----------------------------------------------------------
> 
> (Updated 2009-10-04 00:09:12)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this creates a framework for shells to configure the set of default ContainmentActions plugins for each type of containment (desktop, panel, etc).
> 
> the patch to kdebase is small so instead of creating a separate review request I'll paste the important bit here:
> 
> @@ -51,6 +52,17 @@ void DesktopCorona::init()
>      Kephal::Screens *screens = Kephal::Screens::self();
>      connect(screens, SIGNAL(screenAdded(Kephal::Screen *)), SLOT(screenAdded(Kephal::Screen *)));
>      connect(KWindowSystem::self(), SIGNAL(workAreaChanged()), this, SIGNAL(availableScreenRegionChanged()));
> +
> +    Plasma::ContainmentActionsPluginsConfig desktopPlugins;
> +    desktopPlugins.addPlugin(Qt::NoModifier, Qt::Vertical, "switchdesktop");
> +    desktopPlugins.addPlugin(Qt::NoModifier, Qt::MidButton, "paste");
> +    desktopPlugins.addPlugin(Qt::NoModifier, Qt::RightButton, "contextmenu");
> +    Plasma::ContainmentActionsPluginsConfig panelPlugins;
> +    panelPlugins.addPlugin(Qt::NoModifier, Qt::RightButton, "contextmenu");
> +
> +    setContainmentActionsDefaults(Plasma::Containment::DesktopContainment, desktopPlugins);
> +    setContainmentActionsDefaults(Plasma::Containment::PanelContainment, panelPlugins);
> +    setContainmentActionsDefaults(Plasma::Containment::CustomPanelContainment, panelPlugins);
>  }
> 
> 
> Diffs
> -----
> 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1029909 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 1029909 
>   /trunk/KDE/kdelibs/plasma/corona.h 1029909 
>   /trunk/KDE/kdelibs/plasma/corona.cpp 1029909 
> 
> Diff: http://reviewboard.kde.org/r/1760/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>