Review Request: WebView Kinetic Scrolling

Marco Martin notmart at gmail.com
Sat Oct 3 15:16:23 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1764/#review2534
-----------------------------------------------------------

Ship it!


apart a couple of stye issues it's ok


trunk/KDE/kdelibs/plasma/widgets/webview.cpp
<http://reviewboard.kde.org/r/1764/#comment1859>

    if (event->pos().x()



trunk/KDE/kdelibs/plasma/widgets/webview.cpp
<http://reviewboard.kde.org/r/1764/#comment1860>

    if (me.isAccepted()) {



trunk/KDE/kdelibs/plasma/widgets/webview.cpp
<http://reviewboard.kde.org/r/1764/#comment1861>

    also there, no spaces


- Marco


On 2009-10-03 13:07:41, igorto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1764/
> -----------------------------------------------------------
> 
> (Updated 2009-10-03 13:07:41)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> Add support for kinetic scrolling in webview widget.
> 
> TODO:
> 
> -Make Horizontal Kinetic Scrolling works
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/webview.h 1030897 
>   trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1030897 
> 
> Diff: http://reviewboard.kde.org/r/1764/diff
> 
> 
> Testing
> -------
> 
> webbrowser
> 
> 
> Thanks,
> 
> igorto
> 
>



More information about the Plasma-devel mailing list