Review Request: Delay for updating shape of itemBackground

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1756/#review2524
-----------------------------------------------------------

Ship it!


ah, that explains something i've been seeing ocassionally in plasma netbook. please commit :)

- Aaron


On 2009-10-02 08:36:48, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1756/
> -----------------------------------------------------------
> 
> (Updated 2009-10-02 08:36:48)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> Delay updating the shape of the itemBackground after some change event to allow the parent of the target item to resize itself; 
> what happens right now is that itemBackground grabs the event before the parent and is cut if the parent needs to be resized and has the itemClipsChildrenToShape flag set.     
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/itembackground.h 1030313 
>   trunk/KDE/kdelibs/plasma/widgets/itembackground.cpp 1030313 
> 
> Diff: http://reviewboard.kde.org/r/1756/diff
> 
> 
> Testing
> -------
> 
> it works as expected, the parent is resized beforehand and clipping does not occur.
> 
> 
> Thanks,
> 
> Jacopo
> 
>