Qalculate plasmoid in kdeplasma-addons

[Matteo Agostinelli]

On Thursday 01 October 2009 18:25:39 you wrote:
> On October 1, 2009, Matteo Agostinelli wrote:
> > On Wed, Sep 30, 2009 at 19:29, Aaron J. Seigo <aseigo at kde.org> wrote:
> > > On September 30, 2009, Matteo Agostinelli wrote:
> > >> Also, I would like to add that this is not meant to be a replacement
> > >> of the existing calculator but an optional "enhanced" calculator,
> > >> since it requires an additional external dependency (libqalculate). So
> > >> IMO the current choice of branding (name and icon) could be
> > >> acceptable. If there
> > >
> > > so i finally got it built and found some time to test it. some input:
> > >
> > > * it uses QHttp; it must use KIO instead
> > >
> > > * the network access in QalculateEngine::updateExchangeRates() is
> > > blocking rather than async
> >
> > Is it ok if I use KIO::NetAccess:download()? I see in the
> > documentation that "The functions appear to be blocking, but the Qt
> > event loop continues running while the operations are handled. This
> > means that the GUI will not freeze." So is this function suitable in
> > this case?
> 
> i believe this only allows for repaints, not user interaction with other
> widgets or further processing of non-event driven application code which is
> the important bit in this case. it needs to be properly async.
> 
Ok, I am now using a KIO::Job to async transfer the exchange rates, and also 
the other points have been taken care of. I have just committed the latest 
changes to svn. Can I consider it now ready for kdeplasma-addons :) ?

Matteo