Review Request: Add an hidden option to set a translucent background for DesktopView

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1755/#review2515
-----------------------------------------------------------


anything but the desktop shell painting the wallpaper is poor design. the window manager does not have enough knowledge of what is happening in the shell to do so properly. what, exactly, is the benefit of letting compiz draw the wallpaper? if it's simply visual bling, i'm really not interested in encouraging it by adapting plasma-desktop to such a broken idea.


/trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp
<http://reviewboard.kde.org/r/1755/#comment1840>

    the { should be on a line by itself



/trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp
<http://reviewboard.kde.org/r/1755/#comment1842>

    if (translucent == m_translucentBackground) {
        return;
    }
    
    probably wouldn't hurt so as to avoid unnecessary processing.
    
    given there is a setter and a getter, they may as well be used, e.g. by exposing this in the scripting support in desktop/shell/scripting/containment.cpp



/trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp
<http://reviewboard.kde.org/r/1755/#comment1841>

    shouldn't this set the translucent widget attribute? also, this should have a PlasmaApp::self()->corona()->requestConfigSync(); call to ensure it gets written out to disk.
    


- Aaron


On 2009-10-01 18:07:49, wearenotalone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1755/
> -----------------------------------------------------------
> 
> (Updated 2009-10-01 18:07:49)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Since revision 928340 (http://websvn.kde.org/?view=revision&revision=928340 ) its no longer possible to set a translucent background. Because of this you cannot use the wallpaper plugin of compiz fusion any longer with kde 4. For more information please see this bugreport: https://bugs.kde.org/show_bug.cgi?id=199869
> 
> This patch adds an hidden option named "translucentBackground" (because of Qt::WA_TranslucentBackground) in ~/.kde/share/config/plasma-desktoprc (example):
> 
> ...
> [PlasmaViews][34]
> DashboardContainment=0
> translucentBackground=true
> ...
> 
> The default value of translucentBackground is false, because this is the default behavior at the moment. I also created a patch against the kdebase-workspace-4.3.1 source package of Debian Squeeze, which works fine for me and can be found here: https://bugs.kde.org/show_bug.cgi?id=199869#c10
> 
> Best Regards,
> WANA
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.h 1027876 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp 1027876 
> 
> Diff: http://reviewboard.kde.org/r/1755/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wearenotalone
> 
>