Review Request: Add a tooltip to battery monitor applet
Aaron Seigo
aseigo at kde.org
Wed Nov 25 22:31:44 CET 2009
> On 2009-11-25 18:37:46, Andrew Coles wrote:
> > Proof-reading:
> >
> > 1) Change 'Estimated time remaining %1' to 'Estimated time remaining: %1'. The other items in the tool-tip separate the label from the data using a colon (e.g. Charging: 20% charged), so the time remaining needs to do so too for consistency.
> >
> > 2) In the case of less than an hour of battery life left, I'd recommend:
> >
> > content += i18np("Estimated time remaining: 1 minute", "Estimated time remaining: %1 minutes", m_minutes);
> >
> > ...as this is clearer than, say, "Estimated time remaining: 0:22".
>
> Kåre Särs wrote:
> Those are good points. Lets see if the patch gets support. If it gets the support I'll make a new patch with those changes.
my original comment has not changed. the position hasn't changed in the last year, in fact. the estimated time is a bullshit number far too often, putting such numbers in our primary UI is an awesome way to teach the user to form a relationship of distrust with the system, there is a % capacity level, most other devices i have in the house here that show battery status (which is quite a few) don't show such estimated time information either (ranging from various game consoles to phones to portable devices to laptops; in fact, it's mostly the latter that tries to do this).
so .. tooltip == good, estimated time left == no.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2010/#review3276
-----------------------------------------------------------
On 2009-11-01 09:34:16, Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2010/
> -----------------------------------------------------------
>
> (Updated 2009-11-01 09:34:16)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This path adds a tool-tip for the battery-monitor applet. The tool-tip contains charge percentage and estimated time left.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1041319
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1041319
>
> Diff: http://reviewboard.kde.org/r/2010/diff
>
>
> Testing
> -------
>
> I'm not running trunk, so I had to comment out the setStatus() functions (not done in the patch).
>
>
> Thanks,
>
> Kåre
>
>
More information about the Plasma-devel
mailing list