Review Request: Make folderview's hovering popups more usable

Shafqat Bhuiyan priomsrb at gmail.com
Sun Nov 22 20:56:03 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2262/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch adds two things to make the folderview hovering popups more usable:
1. Don't show popup after user clicks on a folder
2. Close all popups after user clicks on a file/folder

Part 1 should be good for all users. However part 2 make takes away multi-file opening. I think this is the correct behavior because this is how most people are accustomed to hovering popup views(eg classic application launchers). Also if a user wants to open multiple files he/she can just open the folder with the files inside.

This patch isn't too drastic so it may be backported


Diffs
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1052895 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h 1052895 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp 1052895 

Diff: http://reviewboard.kde.org/r/2262/diff


Testing
-------

Tested in trunk


Thanks,

Shafqat



More information about the Plasma-devel mailing list