Review Request: Add improved 'Add Icon' dialog to quicklaunch applet

[Shafqat Bhuiyan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2072/#review3198
-----------------------------------------------------------


This review has been up for about two weeks without comment. So if no one has any objections I'd like to commit it within the next 3 days. It seems more a bug fix than a feature so feature-freeze wise I think it should be ok.

- Shafqat


On 2009-11-04 22:59:44, Shafqat Bhuiyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2072/
> -----------------------------------------------------------
> 
> (Updated 2009-11-04 22:59:44)
> 
> 
> Review request for Plasma, Aaron Seigo and Lukas Appelhans.
> 
> 
> Summary
> -------
> 
> This patch replaces the previous 'Add Icon' dialog with an 'Open With' dialog. This makes it more familiar to users and much easier to use.
> 
> 
> This addresses bug 196198.
>     https://bugs.kde.org/show_bug.cgi?id=196198
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchApplet.h 1044106 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchApplet.cpp 1044106 
> 
> Diff: http://reviewboard.kde.org/r/2072/diff
> 
> 
> Testing
> -------
> 
> Compiles in trunk. Simple testing reveals no problems.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/2072/s/252/
> 
> 
> Thanks,
> 
> Shafqat
> 
>