Review Request: Draft: Widgets Explorer "Add Widgets"

[Marco Martin]

On Thu, Nov 19, 2009 at 7:18 AM, Petri Damstén <petri.damsten at gmail.com> wrote:
> On Tuesday 17 November 2009 11:01:40 Marco Martin wrote:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/2191/#review3141
>> -----------------------------------------------------------
>>
>>
>> ths is absolutely needed, to not face a dig regression in 4.4... can't
>>  really try the patch right now, can you provide a screenshot of it?
>
> Applied the patch, screenshot here:
> http://kotisivu.lumonetti.fi/damu0/images/add-widgets.jpg
>
> Could the button be on the same line with the search and category boxes?
yeah i think right after the input field would be the right place

> Another issues:
> * I'm missing remove and about buttons. At least about dialog would be
> important for kde-look.org plasmoids. Is the Applet info popup right place for
> those?
in the tooltip yes.
scripted plasmoids should already have a remove button by the way?
> * Could the icons have two rows of text?
> * Sometimes search box won't accept focus and clicking desktop does not hide
> widgets explorer (Previous add widgets dialog also had focus on search at
> start which was good imho).

yeah, i already got mad at that problem but still couldn't figure out :/
(interestingly enough the same problem happens with plasma compiled on
windows, so we can't even blame x11 or kwin for that :/)
while in the netbook thing the widget explorer does accept focus, so
it's not a problem of the explorer itself