Review Request: Draft: kstatusnotifieritem and notification integration - systray part

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2122/
-----------------------------------------------------------

(Updated 2009-11-17 20:22:30.790680)


Review request for Plasma.


Changes
-------

simplify and support only the signal


Summary
-------

When a kstatusnotifieriem claims ownership of a notification id, the notification is no longer deleted (the hide timeout remains the same, the delete timeout goes to one hour) a tabbar gets created in an extender item, where is possible to switch between all not expired notification (usual view) and all notifications associated to a given knotificationitem (that is generic enough to be extended to all Task subclasses, like plasmoidtasks in the future)


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/manager.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/manager.cpp 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/notification.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/notification.cpp 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/protocol.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/task.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/notifications/dbusnotificationprotocol.cpp 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/notificationwidget.h 1050508 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/notificationwidget.cpp 1050508 

Diff: http://reviewboard.kde.org/r/2122/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.kde.org/r/2122/s/258/


Thanks,

Marco