Review Request: Add support for single Runner queries to krunner (part I: libplasma)

[Jacopo De Simoi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
-----------------------------------------------------------

(Updated 2009-11-17 17:52:14.417634)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
-------

In order for the runner to be exposed by krunner as single runner query mode (SRQM) enabled, the relative .desktop file must now provide the 
"SingleRunnerQueryMode" key set to true; this allows the runnerManager to load and keep loaded the SRQM-enabled runners even if the user does not want them in the main krunner window results. 
A certain amount of bookkeeping has to be done to ensure that everything works properly; the implementation attempts to minimize that and minimize the risk of breakage.

All previous review comments have been taken into account


Summary
-------

This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars)


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1048133 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1050508 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
-------


Thanks,

Jacopo