Review Request: Patch proposed for arrow navigation in Krunner

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2190/#review3140
-----------------------------------------------------------

Ship it!


hmm, thinking about it that behaviour of qt makes kinda sense, even if it's annoying.
the patch looks sensible tough

- Marco


On 2009-11-17 05:40:46, Anselmo Melo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2190/
> -----------------------------------------------------------
> 
> (Updated 2009-11-17 05:40:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch proposed by Jean-Baptiste Rouault as a solution for bug 211578, regarding arrow keys navigation in krunner's results list.
> 
> In his words:
> "Patch to interface.cpp that seems to resolve the above issue
> 
> The above is a small workaround to fix the issue.
> 
> The problem is that the scene never receive a QEvent::WindowActivate event
> because its widget is hidden when KRunner window is shown. I looked at
> QGraphicsScene code, if a scene never receive the above event, it is considered
> inactive and it can't take the focus.
> Maybe a bug should be filed upstream about this issue ?"
> 
> 
> This addresses bug 211578.
>     https://bugs.kde.org/show_bug.cgi?id=211578
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1049196 
> 
> Diff: http://reviewboard.kde.org/r/2190/diff
> 
> 
> Testing
> -------
> 
> On Krunner, type something that produces a list of results, for example, "kon" . then TAB takes the selection to the list and now arrows can be used to navigate.
> 
> 
> Thanks,
> 
> Anselmo
> 
>