Review Request: comic plasmoid - stop the reload timer when not using tabs or when only having one tab

Bruno Bigras bigras.bruno at gmail.com
Tue Nov 17 07:55:10 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2192/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

The comic plasmoid has a nice feature that allow to automaticaly switch between different source of comic.

I noticed that if you disable the "use tabs" config option, the timer was still running.

Also I think it don't make sense to run the timer if there's only one tab.

Without this change we see the busy animation each 10 seconds (by default) for no reason.


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 1045605 

Diff: http://reviewboard.kde.org/r/2192/diff


Testing
-------


Thanks,

Bruno



More information about the Plasma-devel mailing list