Review Request: Add support for single Runner queries to krunner (part II: krunner)
Aaron Seigo
aseigo at kde.org
Tue Nov 17 01:03:06 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/#review3130
-----------------------------------------------------------
Ship it!
- Aaron
On 2009-11-16 23:50:00, Jacopo De Simoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2091/
> -----------------------------------------------------------
>
> (Updated 2009-11-16 23:50:00)
>
>
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
>
>
> Summary
> -------
>
> This patch adds single runner query support to krunner;
> When loading the runners, if any runner supports a defaultSyntax, then this is exposed via an action which shows up in the global shortcuts;
> When this action is triggered, krunner starts in single-runner-query mode; i.e. queries are processed by the selected runner only; the interfaces changes slightly to reflect this fact (screenshot) and the query given by the default syntax is automatically run.
>
> Also a convenient dbus interface is added, in case we want to trigger this internally;
>
> The most obvious usecase is the windows runner; an upcoming devicerunner and also the nepomuk search runner could make use of this feature.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190
> trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190
> trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1046190
> trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp 1046190
> trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h 1046190
> trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp 1046190
> trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190
> trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190
> trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190
> trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190
>
> Diff: http://reviewboard.kde.org/r/2091/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Window runner in single runner mode (+descriptive label)
> http://reviewboard.kde.org/r/2091/s/264/
>
>
> Thanks,
>
> Jacopo
>
>
More information about the Plasma-devel
mailing list