Review Request: plasmaengineviewer scroll fix for bug #213594

Marco Martin notmart at gmail.com
Sun Nov 15 21:54:31 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2170/#review3111
-----------------------------------------------------------

Ship it!


seems fine

- Marco


On 2009-11-14 14:33:44, Roman Fietze wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2170/
> -----------------------------------------------------------
> 
> (Updated 2009-11-14 14:33:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Fix bug #213594 by not removing all elements of a subtree when updating it, but overwrite existing nodes and just remove the supernumerous ones. BTW, I do not have SVN write access.
> 
> 
> This addresses bug 213594.
>     https://bugs.kde.org/show_bug.cgi?id=213594
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.h 1047140 
>   trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp 1047140 
> 
> Diff: http://reviewboard.kde.org/r/2170/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> plasmaengineexplorer
>   http://reviewboard.kde.org/r/2170/s/259/
> 
> 
> Thanks,
> 
> Roman
> 
>



More information about the Plasma-devel mailing list