Review Request: Support translations in Runner and DataEngine packages

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2134/#review3035
-----------------------------------------------------------

Ship it!


* Are translations needed in DataEngine packages?

yes; it's not overly common, but there are some engines already that have translated strings.

* Can Runner use PlasmoidPackage? Translations and ui files are possible.

i think it probably can; in the past there were issues with this, but i believe that it's been resolved. so PackageStructure::Ptr defaultPackageStructure(ComponentType type) could be fixed / simplified.

- Aaron


On 2009-11-11 10:21:23, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2134/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 10:21:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> * Are translations needed in DataEngine packages?
> * Can Runner use PlasmoidPackage? Translations and ui files are possible.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/scripting/scriptengine.cpp 1047395 
>   /trunk/KDE/kdelibs/plasma/dataengine.cpp 1047395 
>   /trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1047395 
>   /trunk/KDE/kdelibs/plasma/private/dataengine_p.h 1047395 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1047395 
> 
> Diff: http://reviewboard.kde.org/r/2134/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>