Review Request: Fix Plasma CalendarTable widget for RTL

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2088/#review2967
-----------------------------------------------------------

Ship it!


seems good, just that small issue.


trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp
<http://reviewboard.kde.org/r/2088/#comment2426>

    are you sure that klocale can't do that instead of using this ugly composition?
    if it can be avoided, something prettier than weekstring/weekstring2 ok? :p


- Marco


On 2009-11-07 01:24:54, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2088/
> -----------------------------------------------------------
> 
> (Updated 2009-11-07 01:24:54)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The CalendarTable widget does not correctly display in RTL mode, the cells in the table go LTR instead.  The numbers in the cells are controlled by code and not the widget layout, so we need to handle this the code.  
> 
> This patch fixes the day numbers, weekday names, and week numbers to go RTL, see screenshots for example.  It doesn't move the Week Numbers column from the left to the right as this is part of the SVG, we would need to flip the SVG along it's vertical axis to do so and shuffle everything about.  Is this possible or too much effort?  
> 
> Also rename a couple of variables for clarity seeing as I now understand what they do.
> 
> Patch against trunk, I'll backport to 4.3 if all OK.  Note we may want to rewrite some of the CalendarTable in 4.5 for a cleaner implementation.
> 
> cc to Dotan to confirm this looks OK and to confirm it's not a problem if we can't move the Week Number column.
> 
> 
> This addresses bug 182976.
>     https://bugs.kde.org/show_bug.cgi?id=182976
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1043597 
> 
> Diff: http://reviewboard.kde.org/r/2088/diff
> 
> 
> Testing
> -------
> 
> Tested using 'plasmoidviewer --reverse calendar'
> 
> 
> Screenshots
> -----------
> 
> Left to Right mode
>   http://reviewboard.kde.org/r/2088/s/253/
> Right to Left mode
>   http://reviewboard.kde.org/r/2088/s/254/
> 
> 
> Thanks,
> 
> John
> 
>