Review Request: Adds Firefox bookmark support to the bookmark runner

[Jan Gerrit Marker]

> On 2009-11-06 18:36:22, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp, line 48
> > <http://reviewboard.kde.org/r/2085/diff/2/?file=13834#file13834line48>
> >
> >     web browser (space)

Oops, English not as first language ;).
Corrected


> On 2009-11-06 18:36:22, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp, lines 262-263
> > <http://reviewboard.kde.org/r/2085/diff/2/?file=13834#file13834line262>
> >
> >     hm; a bit of an odd way of saying:
> >     
> >     if (allBookmarks || title.contains(term) || url.path().contains(term))

Ok, fixed.


- Jan Gerrit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2085/#review2953
-----------------------------------------------------------


On 2009-11-06 18:17:32, Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2085/
> -----------------------------------------------------------
> 
> (Updated 2009-11-06 18:17:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds Firefox support to the bookmark runner. The database, where the bookmarks are saved in, is copied and then used for getting the bookmarks. The support was added a way that you can add other browsers easily (e.g. by adding a method "whichBrowser()", an enumeration "Browser" and own methods for each browser (Firefox and Konqueror at the moment)). The path to the original database file is stored in the runners configuration group. The browser to get the bookmarks from is taken from the command set in the applications systemsettings module.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/CMakeLists.txt 1045755 
>   trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.h 1045755 
>   trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1045755 
> 
> Diff: http://reviewboard.kde.org/r/2085/diff
> 
> 
> Testing
> -------
> 
> I tested it and it was fine with Firefox 3.5.4 and Konqueror from trunk.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>