Review Request: Adds Firefox bookmark support to the bookmark runner

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2085/#review2959
-----------------------------------------------------------

Ship it!


cool beans; i wonder if anyone will offer opera or arora support in the future? let's see! :)


trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp
<http://reviewboard.kde.org/r/2085/#comment2396>

    pure awesome; i heart databases.
    
    (guess what i used to do in a previous life? :)


- Aaron


On 2009-11-06 19:27:01, Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2085/
> -----------------------------------------------------------
> 
> (Updated 2009-11-06 19:27:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds Firefox support to the bookmark runner. The database, where the bookmarks are saved in, is copied and then used for getting the bookmarks. The support was added a way that you can add other browsers easily (e.g. by adding a method "whichBrowser()", an enumeration "Browser" and own methods for each browser (Firefox and Konqueror at the moment)). The path to the original database file is stored in the runners configuration group. The browser to get the bookmarks from is taken from the command set in the applications systemsettings module.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/CMakeLists.txt 1045784 
>   trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.h 1045784 
>   trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1045784 
> 
> Diff: http://reviewboard.kde.org/r/2085/diff
> 
> 
> Testing
> -------
> 
> I tested it and it was fine with Firefox 3.5.4 and Konqueror from trunk.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>