Review Request: Additional style options for TaskManager e.g. "Icon only"

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1342/
-----------------------------------------------------------

(Updated 2009-11-06 13:23:47.324879)


Review request for Plasma.


Changes
-------

Just added something in the description to get this request at the top of the list again....


Summary (updated)
-------

The attached diff adds three style options to the task manager widget.

In addition to the "normal" icon-and-text style you can now have a icon-only, 
text-only or text-under-icon style.

This means that e.g. the tasks are displayed by icon only (a much bigger icon 
though).

The additional styles are especially useful if you have a vertical panel. In 
the icon-and-text style I only had five characters of the task name left.

The new styles can be selected in the "Task Manager Settings". Default is the 
Windows like icon-and-text.

Heyho...
Don't anyone want to review this?


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1010427 
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1010427 
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.h 1010427 
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp 1010427 
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasksConfig.ui 1010427 

Diff: http://reviewboard.kde.org/r/1342/diff


Testing
-------

Tried all possible combinations of style options.

Note: Manual grouping does not seem but work, but I couldn't get this to work with the original either.


Thanks,

Ralf