Review Request: Add searched applications to the Recent list in Kickoff.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2059/#review2924
-----------------------------------------------------------

Ship it!


looks good to me

- Marco


On 2009-11-04 14:19:21, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2059/
> -----------------------------------------------------------
> 
> (Updated 2009-11-04 14:19:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I use Kickoff's search bar to quickly find applications and launch it from the results shown most of the time.
> 
> However, launching applications from these search results does not register an entry into the Recently Used Applications list of Kickoff.
> 
> This patch aims to fix this issue - by retrieving the name of the "service" launched from the krunner:// url (which the search results carry) and adding the service object created from it to the RecentApplications list.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/core/krunnermodel.cpp 1043899 
> 
> Diff: http://reviewboard.kde.org/r/2059/diff
> 
> 
> Testing
> -------
> 
> * Tried with applications I have installed - Firefox, various KDE Games (kde4-* entries), OpenOffice.org applications. All show up properly (without dupes) in recently used list after being launched from the search results.
> 
> 
> Thanks,
> 
> Harsh
> 
>