Review Request: Add missing functions to RunnerScript

Aaron Seigo aseigo at kde.org
Tue Nov 3 21:15:02 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2054/#review2917
-----------------------------------------------------------



/trunk/KDE/kdelibs/plasma/abstractrunner.h
<http://reviewboard.kde.org/r/2054/#comment2320>

    these should only be signals in RunnerScript, not AbstractRunner.
    
    make AbstractRunner a friend of RunnerScript and AbstractRunner can then emit those signals directly.


- Aaron


On 2009-11-03 18:41:40, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2054/
> -----------------------------------------------------------
> 
> (Updated 2009-11-03 18:41:40)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add missing functions to RunnerScript. Initial python support ready.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.h 1044136 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1044136 
>   /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h 1044136 
>   /trunk/KDE/kdelibs/plasma/scripting/runnerscript.cpp 1044136 
> 
> Diff: http://reviewboard.kde.org/r/2054/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>



More information about the Plasma-devel mailing list