Review Request: Add missing functions to RunnerScript

[Aaron Seigo]

> On 2009-11-03 17:06:58, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h, lines 87-98
> > <http://reviewboard.kde.org/r/2054/diff/1/?file=13668#file13668line87>
> >
> >     can't add new virtual members; it's BIC. the prepare and teardown slots are unecessary as the signals can be connected to.
> 
>  wrote:
>     Should I just remove those for now or?

at least two of them can be made into signals; actionsForMatch will prove more difficult. so i'd say provide four signals (createRunOptions, reloadConfiguration, prepare and teardown) and we'll figure out actionsForMatch later.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2054/#review2902
-----------------------------------------------------------


On 2009-11-03 08:36:35, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2054/
> -----------------------------------------------------------
> 
> (Updated 2009-11-03 08:36:35)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add missing functions to RunnerScript. Initial python support ready.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.h 1044136 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1044136 
>   /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h 1044136 
>   /trunk/KDE/kdelibs/plasma/scripting/runnerscript.cpp 1044136 
> 
> Diff: http://reviewboard.kde.org/r/2054/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>