Review Request: plasmapkg & wallpaper

[Petri Damstén]

> On 2009-11-03 17:07:50, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp, lines 137-138
> > <http://reviewboard.kde.org/r/2006/diff/2/?file=13546#file13546line137>
> >
> >     does this work for zip'd up packages as well?

Plasma::PackageStructure reads metadata from zip files and it's used like this later in the code. I tested it with wallpaper plugin, runner and dataengine packages and it correctly identified those. It does not identify wallpaper image package automatically (it would have to read zip file directly?).


- Petri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2006/#review2903
-----------------------------------------------------------


On 2009-10-30 08:07:28, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2006/
> -----------------------------------------------------------
> 
> (Updated 2009-10-30 08:07:28)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> * install wallpaper plasma packages
> * auto detect (plasmoids,) dataengines, runners and wallpapers (install them without --type)
> * Remove previous package also with --install
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1042090 
> 
> Diff: http://reviewboard.kde.org/r/2006/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>