Review Request: Add "reply" and "retweet" buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

[Marco Martin]

On Tuesday 03 November 2009, Nicolas Réau wrote:
> > On 2009-11-02 17:34:56, Marco Martin wrote:
> > > /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp, line 554
> > > <http://reviewboard.kde.org/r/2032/diff/1/?file=13582#file13582line554>
> > >
> > >     everything in the tweetframe should become a single Anchorlayout.
> > > eventually after commit too
> 
> You mean changing the 'tweetlayout' from QGraphicsLinearLayout to
>  QGraphicsAnchorLayout and arrange items inside it?
> 

yep, now there are a bit of nested layouts, it would be possible to use a 
single one, i also think that the tweet widget should become a separate file, 
a Frame subclass with everything in it, it would simplify the logic of the 
plasmoid that is waaay too convoluted now

> - Nicolas
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2032/#review2893
> -----------------------------------------------------------
> 
> On 2009-11-02 19:11:15, Nicolas Réau wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/2032/
> > -----------------------------------------------------------
> >
> > (Updated 2009-11-02 19:11:15)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > I followed what i think is the most common behavior on Twitter/Identica
> > which is to reply to someone by writing @<hisname> at the beginning of
> > your reply. For the retweet I adopted this: RT: @<hisname> <hismessage>
> >
> > There is a wish report on b.k.o asking for this same behavior. However
> > this can be discussed, as I don't know if it's admitted as being the good
> > behavior.
> >
> >
> > This addresses bug https://bugs.kde.org/show_bug.cgi?id=177906.
> >    
> > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id
> >=177906
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.h 1043945
> >   /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp 1043945
> >
> > Diff: http://reviewboard.kde.org/r/2032/diff
> >
> >
> > Testing
> > -------
> >
> > Clicking the "@" button give the focus and scroll up to textedit box,
> > with @<username> written in it, and cursor at the end Clicking the "RT"
> > button give the focus and scroll up to textedit box, with RT: @<username>
> > <status> written in it, and cursor at the beginning The 2 buttons are not
> > shown inside your own tweets/dents
> >
> >
> > Screenshots
> > -----------
> >
> > Reply and retweet buttons
> >   http://reviewboard.kde.org/r/2032/s/244/
> >
> >
> > Thanks,
> >
> > Nicolas
> 


-- 
Marco Martin