Review Request: wetter.com Weather Ion

Thilo-Alexander Ginkel thilo at ginkel.com
Mon Nov 2 21:56:11 CET 2009


On Monday 02 November 2009 21:46:12 Aaron Seigo wrote:
> > I have removed the QObject inheritance in my current working copy.
> 
> the Ions are QObjects primarily for memory management; since the Ion
>  plugins tend to have signal/slot connections they'd end up subclassing
>  QObject and so it just made sense to make Ion a QObject as well and use
>  the benefits inherent to that. also, if we ever make scripted Ions, having
>  Ion as a QObject makes it easier to bind.

Sorry, my wording apparently was kind of ambiguous: I have removed the QObject 
inheritance for WetterComIon::Private (the d-pointer class), not for the main 
Ion class (WetterComIon), where inheriting from QObject definitely makes sense 
for various reasons.

Regards,
Thilo


More information about the Plasma-devel mailing list