Review Request: Add "reply" and "retweet" buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

Nicolas Réau thelwyn at gmail.com
Mon Nov 2 20:11:15 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2032/
-----------------------------------------------------------

(Updated 2009-11-02 19:11:15.641060)


Review request for Plasma.


Changes
-------

-Changed sltReply to reply , and 'answer' to 'reply' everywhere.
-Changed also retweet to 'forward' (IMHO better than postAgain).
-I didn't touch the icons and anchorlayout thing.


Summary
-------

I followed what i think is the most common behavior on Twitter/Identica which is to reply to someone by writing @<hisname> at the beginning of your reply. For the retweet I adopted this: RT: @<hisname> <hismessage>

There is a wish report on b.k.o asking for this same behavior. However this can be discussed, as I don't know if it's admitted as being the good behavior.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=177906.
    https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=177906


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.h 1043945 
  /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp 1043945 

Diff: http://reviewboard.kde.org/r/2032/diff


Testing
-------

Clicking the "@" button give the focus and scroll up to textedit box, with @<username> written in it, and cursor at the end
Clicking the "RT" button give the focus and scroll up to textedit box, with RT: @<username> <status> written in it, and cursor at the beginning
The 2 buttons are not shown inside your own tweets/dents


Screenshots
-----------

Reply and retweet buttons
  http://reviewboard.kde.org/r/2032/s/244/


Thanks,

Nicolas



More information about the Plasma-devel mailing list